Conversation
added 3 commits
June 20, 2025 00:47
Owner
|
Hi @anmolitor, thanks for your contribution again! I'm aware of this PR, but I can't have a solid time to look into and publish it right now. I'm trying to have time in July. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #806
I don't really get why I have to return different things from resolveId depending on if the source came
from an elm importer or from somewhere else (js/ts).
Maybe you have more context of the rest of the source code and can explain/refactor/give me a hint.
This works for me in https://gitlab.com/andreasewering/safari-zone which is a pretty large elm codebase so I hope it works in general 🤞